Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH v4 1/1] can: add pruss CAN driver. | Date | Thu, 12 May 2011 14:54:47 +0200 |
| |
On Thursday 12 May 2011, Wolfgang Grandegger wrote: > Well, that seems sophisticated resulting in a complex implementation > (may code line) also because hardware filters are very hardware > dependent. Usually just one global filter can be defined. I think that's > overkill. A simple interface using: > > ip link set can0 type can filter <id>:<mask> [<id>:<mask> ...] > > would just be fine.
Ok, fair enough. Still I would suggest you first come up with a reasonable user interface (the one you posted may be just right, I don't know), and then let someone do the implementation in the pruss firmware that is the best match for the user interface, rather than the other way around.
Arnd
| |