Messages in this thread | | | Date | Wed, 11 May 2011 18:07:11 -0700 | From | Randy Dunlap <> | Subject | Re: [PATCH] arch/c6x: new architecture port for linux |
| |
On Wed, 11 May 2011 20:57:53 -0400 Mark Salter wrote:
> On Wed, 2011-05-11 at 14:34 -0700, Randy Dunlap wrote: > > Please run the patches thru checkpatch.pl. You don't have to fix > > everything that it whines about, just use good judgment. > > Thanks Randy. > > Was there anything particular that jumped out at you. I did run > checkpatch and there were 7 seven errors but none seemed fixable to > me (unless there really is a way to get rid of kernel_thread). The > warnings were almost all about exceeded 80 char line width. I have > been working on those for a while and there's a lot less than there > used to be! :-)
There was one in drivers/platform/c6x/ where a driver included asm/timer.h instead of linux/timer.h (IIRC - I don't have the patch handy ATM to run it again). checkpatch said to use linux/ instead of asm/.
--- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***
| |