Messages in this thread |  | | | From | Andi Kleen <> | | Subject | Re: [PATCH 3/3] x86, cpu: Enable/disable SMEP | | Date | Wed, 11 May 2011 15:36:30 -0700 |
| |
"Fenghua Yu" <fenghua.yu@intel.com> writes:
> +static int disable_smep;
If you add a __initdata here the whole thing will completely disappear after boot.
> @@ -867,6 +886,8 @@ static void __cpuinit identify_cpu(struct cpuinfo_x86 *c) > /* Init Machine Check Exception if available. */ > mcheck_cpu_init(c); > > + setup_smep(c);
My feeling is you're setting this too late. In theory there could be early overflows. Better use a early_param and set it as early as possible, directly after the cpuid flags are set up in early initialization.
-Andi -- ak@linux.intel.com -- Speaking for myself only
|  |