lkml.org 
[lkml]   [2011]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] perf: Carve out callchain functionality
    On Wed, May 11, 2011 at 09:30:12AM -0400, Frederic Weisbecker wrote:
    > > +extern int get_recursion_context(int *recursion);
    > > +extern inline void put_recursion_context(int *recursion, int rctx);
    > > +extern void put_callchain_buffers(void);
    > > +extern struct perf_callchain_entry *perf_callchain(struct pt_regs *regs);
    > > +extern int get_callchain_buffers(void);
    >
    > I think it would be better to have these in a private kernel/events/events.h
    >
    > Other than that, looks good, thanks.

    Yeah, I suggested a new header originally too but Ingo wanted to keep
    perf_event.h as is, for now.

    > Acked-by: Frederic Weisbecker <fweisbec@gmail.com>

    Thanks.

    --
    Regards/Gruss,
    Boris.

    Advanced Micro Devices GmbH
    Einsteinring 24, 85609 Dornach
    General Managers: Alberto Bozzo, Andrew Bowd
    Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
    Registergericht Muenchen, HRB Nr. 43632


    \
     
     \ /
      Last update: 2011-05-11 17:47    [W:0.029 / U:31.872 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site