lkml.org 
[lkml]   [2011]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
FromNamhyung Kim <>
Subject[PATCH] blk-throttle: get rid of wrong initialization of 'limits_changed'
DateWed, 11 May 2011 23:50:43 +0900
When a new group is initialized, we should set @tg->limits_changed
to false instead of setting @td->limits_changed. But @td and @tg
are initialized to zero via kzalloc_node(), there is no need to set
it explicitly. Just get rid of them.

Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Cc: Vivek Goyal <vgoyal@redhat.com>
---
block/blk-throttle.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/block/blk-throttle.c b/block/blk-throttle.c
index 0475a22a420d..5e241ce2695b 100644
--- a/block/blk-throttle.c
+++ b/block/blk-throttle.c
@@ -201,7 +201,6 @@ static struct throtl_grp * throtl_find_alloc_tg(struct throtl_data *td,
RB_CLEAR_NODE(&tg->rb_node);
bio_list_init(&tg->bio_lists[0]);
bio_list_init(&tg->bio_lists[1]);
- td->limits_changed = false;

/*
* Take the initial reference that will be released on destroy
@@ -1060,7 +1059,6 @@ int blk_throtl_init(struct request_queue *q)

INIT_HLIST_HEAD(&td->tg_list);
td->tg_service_tree = THROTL_RB_ROOT;
- td->limits_changed = false;

/* Init root group */
tg = &td->root_tg;
@@ -1072,7 +1070,6 @@ int blk_throtl_init(struct request_queue *q)
/* Practically unlimited BW */
tg->bps[0] = tg->bps[1] = -1;
tg->iops[0] = tg->iops[1] = -1;
- td->limits_changed = false;

/*
* Set root group reference to 2. One reference will be dropped when
--
1.7.5


\
 
 \ /
  Last update: 2011-05-11 18:47    [from the cache]
©2003-2010