Messages in this thread |  | | | Date | Tue, 10 May 2011 09:57:27 +0200 (CEST) | | From | Julia Lawall <> | | Subject | Re: [PATCH] drivers/mmc/card/block.c: fix potential null dereference 'idata' |
| |
On Tue, 10 May 2011, Andy Shevchenko wrote:
> On Mon, May 9, 2011 at 7:12 PM, Julia Lawall <julia@diku.dk> wrote: > > I guess there is also a point at which idata has been successfully > > allocated but idata->buf has not. > And? kfree() simple ignores NULL pointers.
Unnecessarily calling a function suggests that calling that function is necessary when it is not. But it is probably not a big deal, especially for a well known function like kfree.
julia
> I would prefer to see previous version of patch, but let maintainer to choose. > > -- > With Best Regards, > Andy Shevchenko >
|  |