Messages in this thread | | | Subject | Re: [PATCH] omap2/omapfb: make DBG() more resistant in if-else constructions | From | Tomi Valkeinen <> | Date | Tue, 10 May 2011 15:08:05 +0300 |
| |
On Tue, 2011-05-10 at 11:42 +0200, Geert Uytterhoeven wrote:
> What about using the standard pr_debug()/dev_dbg() instead? > With dynamic debug, it can be enabled at run time. > As a bonus, you get printf()-style format checking if debugging is disabled.
Yes, dev_dbg & co. would be better.
However, one thing I dislike about them is the extra stuff they print. For example, for omapfb and omapdss dev_dbg will print:
omapfb omapfb: foo omapdss_dss omapdss_dss: foo
I originally added the debug macros to omapdss to be able to automatically print the DSS module name, as at that point there was only one big omapdss device. And I guess I just followed with similar macro in omapfb also. But I believe both omapdss and omapfb should be changed to dev_* prints sometime soon.
Tomi
| |