lkml.org 
[lkml]   [2011]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: re-enable Nehalem raw Offcore-Events support

* stephane eranian <eranian@googlemail.com> wrote:

> > Thirdly, and this is my most fundamental objection, i also object to the
> > timing of this offcore raw access ABI, because past experience is that we
> > *really* do not want to allow raw PMU details without *first* having
> > generic abstractions and generic events first.
>
> I am not opposed to generic events. [...]

Ok - and that's the most important point really.

> [...] But I don't think they're the ultimate solution to all your performance
> problems: the crystal ball you're trying to sell.

I do not claim that and i'm not selling a crystal ball either.

I just see that 90%+ of our users use generic events (most in fact just use
whatever comes as a default, which is cycles) and only a tiny niche uses raw
events. I'm responding to that demand.

[ We saw that with Oprofile already: only an exceedingly small minority *ever*
made use of any event but the default Oprofile came with.

So even with our current generalizations we have more than the typical
developer would use for profiling and we try to not define everything and the
kitchen sink but respond to demand in a common sense way as we see it. ]

And note that i have no problems with and no prejudices against crazy niches
(-rt, anyone?), as long as they *know* that they are crazy and as long as they
help the advancement of the common case!

Really, as a Linux kernel maintainer i'm very easily corrupted by niches: if
you want me to care about your niche you only need to bribe me with
improvements to the more common case! :-)

Note that time is running out to get the offcore bits activated even in
v2.6.40: we are at -rc7 and the merge window is getting closer.

So if you guys care about this code please have a look at Peter's patch and
help test/finish it (or provide a detailed and convincing technical review of
his patch to prove why his approach to provide node level events is impossible
to meet).

Arguing in this thread some more wont help get the code changed i'm afraid!

Thanks,

Ingo


\
 
 \ /
  Last update: 2011-05-10 11:39    [W:0.102 / U:0.204 seconds]
©2003-2014 Jasper Spaans. Advertise on this site