lkml.org 
[lkml]   [2011]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] sched: fix erroneous sysct_sched_nr_migrate logic
From
Date
On Fri, 2011-05-06 at 14:02 +0400, Vladimir Davydov wrote:
>
> But looking through the code, I found the definition:
>
> /* * Number of tasks to iterate in a single balance run. * Limited
> because this is done with IRQs disabled. */ const_debug unsigned int
> sysctl_sched_nr_migrate = 32;
>
> However, AFAIS from the code, the number of tasks to iterate is
> virtually unlimited. So I conclude either the comment is confusing, or
> the logic is wrong.
>

Right, so I mostly agree with your (haven't actually read your patch
yet), the one worry I have is that we'll get stuck endlessly trying to
balance the first cgroup and when there's enough tasks in there but not
enough weight, we'll get stuck not making much progress.

This is one of the many things with the whole cgroup mess that needs
proper sorting out.

So yes, I agree with your interpretation of the sysctl, but I don't
think a straight fwd accounting 'fix' will actually result in a better
kernel.





\
 
 \ /
  Last update: 2011-05-10 11:09    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site