Messages in this thread | | | From | Axel Lin <> | Date | Tue, 10 May 2011 16:54:23 +0800 | Subject | Re: [PATCH] regulator: Move VCOINCELL to be the last element of mc13892_regulators array |
| |
hi Liam,
> Applied, Btw is this fix also for 2.6.39 ?
I check this patch again and found this actually is not a bug because MC13xxx_DEFINE explictly defines the order of each entry in the array.
#define MC13xxx_DEFINE(prefix, _name, _reg, _vsel_reg, _voltages, _ops) \ [prefix ## _name] = { \ .desc = { \ .name = #prefix "_" #_name, \ .n_voltages = ARRAY_SIZE(_voltages), \ .ops = &_ops, \ .type = REGULATOR_VOLTAGE, \ .id = prefix ## _name, \ .owner = THIS_MODULE, \ }, \ .reg = prefix ## _reg, \ .enable_bit = prefix ## _reg ## _ ## _name ## EN, \ .vsel_reg = prefix ## _vsel_reg, \ .vsel_shift = prefix ## _vsel_reg ## _ ## _name ## VSEL,\ .vsel_mask = prefix ## _vsel_reg ## _ ## _name ## VSEL_M,\ .voltages = _voltages, \ }
Regards, Axel
| |