lkml.org 
[lkml]   [2011]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [RFT/PATCH v2 4/6] x86-64: vclock_gettime(CLOCK_MONOTONIC) can't ever see nsec < 0
    On Thu, Apr 7, 2011 at 3:57 AM, Ingo Molnar <mingo@elte.hu> wrote:
    >
    > * Andy Lutomirski <luto@MIT.EDU> wrote:
    >
    >> +
    >> +     /* wall_time_nsec, vgetns(), and wall_to_monotonic.tv_nsec
    >> +      * are all guaranteed to be nonnegative.
    >> +      */
    >
    >> +     /* wall_time_nsec and wall_to_monotonic.tv_nsec are
    >> +      * guaranteed to be between 0 and NSEC_PER_SEC.
    >> +      */
    >
    > Nor have you addressed stylistic review feedback i gave before ...
    >
    > Really, we absolutely must insist on 110% attention to small details for
    > patches that modify assembly code.

    Crud, I fixed most of those. I'll get these in v3. (I assume you're
    talking about comment style.)

    --Andy

    >
    > Thanks,
    >
    >        Ingo
    >
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-04-07 22:57    [W:0.023 / U:90.088 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site