[lkml]   [2011]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 5/5] driver core: let dev_set_drvdata return int instead of void as it can fail
    On 04/06/2011 02:54 PM, Uwe Kleine-König wrote:
    > Signed-off-by: Uwe Kleine-König <>
    > ---
    > Hello,
    > I wasn't sure what to return when dev_set_drvdata is called with
    > dev=NULL. I choosed 0, but -EINVAL would be OK for me, too. What do you
    > think?


    I feel -EINVAL would be more appropriate here.
    Return value of 0 would mean drvdata is set properly, which is not the case.

    Otherwise, patch series looks fine to me. Please add my reviewed-by for all patches.

    Reviewed-by: Viresh Kumar <>

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2011-04-06 12:13    [W:0.022 / U:11.672 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site