lkml.org 
[lkml]   [2011]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 5/5] driver core: let dev_set_drvdata return int instead of void as it can fail
    2011/4/6 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
    > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    > ---
    > Hello,
    >
    > I wasn't sure what to return when dev_set_drvdata is called with
    > dev=NULL.  I choosed 0, but -EINVAL would be OK for me, too. What do you
    > think?

    This code was introduced by:

    commit b4028437876866aba4747a655ede00f892089e14
    Author: Greg Kroah-Hartman <gregkh@suse.de>
    Date: Mon May 11 14:16:57 2009 -0700

    Driver core: move dev_get/set_drvdata to drivers/base/dd.c

    Before this patch, driver writers could assume that dev_set_drvdata()
    never fails. And, dev==NULL would cause an imediate NULL dereference
    (equivalent to BUG_ON(!dev), BTW). And, if dev_set_drvdata() fails
    (silently as it is now) it's going to BUG later anyway.

    I think it's best to revert that commit instead of fixing this up.

    Best Regards,
    Michał Mirosław
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-04-06 13:43    [W:2.668 / U:0.200 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site