[lkml]   [2011]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 5/5] driver core: let dev_set_drvdata return int instead of void as it can fail
    2011/4/6 Uwe Kleine-König <>:
    > Hello,
    > On Wed, Apr 06, 2011 at 11:36:46AM +0200, Michał Mirosław wrote:
    >> 2011/4/6 Uwe Kleine-König <>:
    >> > Signed-off-by: Uwe Kleine-König <>
    >> > ---
    >> > Hello,
    >> >
    >> > I wasn't sure what to return when dev_set_drvdata is called with
    >> > dev=NULL.  I choosed 0, but -EINVAL would be OK for me, too. What do you
    >> > think?
    >> Why not just BUG_ON(!dev)? Is there a case when you might call this
    >> with dev==NULL that's not a driver bug?
    > I think BUG_ON is too harsh. Will resend with -EINVAL.

    Maybe just WARN_ON, then? Please? ;-)

    Error return with no other visible sign is easy to miss for driver
    writers. Big bad backtrace in dmesg on the other hand attracts

    Best Regards,
    Michał Mirosław
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2011-04-06 13:27    [W:0.020 / U:8.164 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site