lkml.org 
[lkml]   [2011]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5/5] driver core: let dev_set_drvdata return int instead of void as it can fail
    Hello,

    On Wed, Apr 06, 2011 at 11:36:46AM +0200, Michał Mirosław wrote:
    > 2011/4/6 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
    > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    > > ---
    > > Hello,
    > >
    > > I wasn't sure what to return when dev_set_drvdata is called with
    > > dev=NULL.  I choosed 0, but -EINVAL would be OK for me, too. What do you
    > > think?
    >
    > Why not just BUG_ON(!dev)? Is there a case when you might call this
    > with dev==NULL that's not a driver bug?
    I think BUG_ON is too harsh. Will resend with -EINVAL.

    Best regards
    Uwe

    --
    Pengutronix e.K. | Uwe Kleine-König |
    Industrial Linux Solutions | http://www.pengutronix.de/ |
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-04-06 13:09    [W:0.054 / U:0.148 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site