Messages in this thread | | | Date | Mon, 4 Apr 2011 21:16:00 -0700 | From | Greg KH <> | Subject | Re: [PATCH 01/12] Staging: hv: Make vmbus driver a pci driver |
| |
On Tue, Mar 15, 2011 at 03:03:32PM -0700, K. Y. Srinivasan wrote: > Make vmbus driver a pci driver. This is > in preparation to cleaning up the root device > management as well as the irq allocation for this > driver. > > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> > Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> > Signed-off-by: Mike Sterling <mike.sterling@microsoft.com> > Signed-off-by: Abhishek Kane <v-abkane@microsoft.com> > Signed-off-by: Hank Janssen <hjanssen@microsoft.com> > --- > drivers/staging/hv/vmbus_drv.c | 63 +++++++++++++++++++++++----------------- > 1 files changed, 36 insertions(+), 27 deletions(-) > > diff --git a/drivers/staging/hv/vmbus_drv.c b/drivers/staging/hv/vmbus_drv.c > index b473f46..1ef2f0f 100644 > --- a/drivers/staging/hv/vmbus_drv.c > +++ b/drivers/staging/hv/vmbus_drv.c > @@ -40,6 +40,8 @@ > #define VMBUS_IRQ 0x5 > #define VMBUS_IRQ_VECTOR IRQ5_VECTOR > > +struct pci_dev *hv_pci_dev;
Why is this global?
Have you forgot to run 'sparse' on your changes?
thanks,
greg k-h
| |