Messages in this thread | | | Date | Tue, 05 Apr 2011 20:46:32 +0100 | From | Jonathan Cameron <> | Subject | Re: [PATCH 1/2] staging: IIO driver for Analog Devices Digital Output Gyroscope ADXRS450 |
| |
On 04/05/11 20:21, Greg KH wrote: > On Fri, Mar 25, 2011 at 12:05:57PM +0800, cliff.cai@analog.com wrote: >> From: Cliff Cai <cliff.cai@analog.com> >> >> Add new IIO driver for Analog Devices digital output gyroscope ADXRS450 >> >> Signed-off-by: Cliff Cai <cliff.cai@analog.com> >> Acked-by: Jonathan Cameron <jic23@cam.ac.uk> > > This breaks the build: > CC [M] drivers/staging/iio/gyro/adxrs450_core.o > drivers/staging/iio/gyro/adxrs450_core.c:329:70: error: expected ‘)’ before numeric constant > drivers/staging/iio/gyro/adxrs450_core.c:337:3: error: ‘iio_dev_attr_gyro_z_quadrature_correction_raw’ undeclared here (not in a function) > drivers/staging/iio/gyro/adxrs450_core.c:216:16: warning: ‘adxrs450_read_quad’ defined but not used > > Please test your patches before you send them out, it wastes everyone's > time when you don't :(
First patch seems to have dropped off the start of this series.
The review version had:
[PATCH 1/3] Add MACRO for gyro quadrature correction
Guessing a typo in git command post adding acks is the culprit here! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |