lkml.org 
[lkml]   [2011]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] ARM: BUG() dies silently
    From
    On Sun, Apr 3, 2011 at 12:15 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
    > (Please stop top posting)
    >
    > On 4/1/2011 3:29 PM, Simon Glass wrote:
    >> Hi Stephen,
    >>
    >> Sorry for the confusion, but in fact I was talking about the patch to
    >> make ARM use the generic bug handling via an undef instruction instead
    >> of calling ______bug() or writing to memory address 0. Please see
    >> here:
    >>
    >> http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=6808/1
    >
    > Yes I've seen your patch (and even posted comments on it which have not
    > been responded to).

    Hi Stephen,

    Not yet! Don't worry I will get to it. I like the suggestion and am
    pleased that you pointed me to it, thank you.

    > Correct me if I'm wrong, but that patch with CONFIG_BUG=n would lead to
    > the same error that Omar is seeing because the code only modifies the
    > bug infrastructure when CONFIG_BUG=y.

    Well if CONFIG_BUG=n then there is no bug infrastructure, The whole
    file is skipped and it falls back to the asm-generic/bug.h which has
    even more #ifdefs in it. But I think we end up here:

    #define BUG() do {} while(0)

    After all the patch removes the *(int*)0 = 0 code by virtue of
    CONFIG_GENERIC_BUG=y, right? If I have this wrong then I will have to
    break out the C preprocessor...

    Regards,
    Simon

    >
    > --
    > Sent by an employee of the Qualcomm Innovation Center, Inc.
    > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
    >
    >


    \
     
     \ /
      Last update: 2011-04-05 03:57    [W:4.687 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site