lkml.org 
[lkml]   [2011]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2.6.39-rc1-tip 18/26] 18: uprobes: commonly used filters.
(2011/04/01 23:36), Srikar Dronamraju wrote:
> Provides most commonly used filters that most users of uprobes can
> reuse. However this would be useful once we can dynamically associate a
> filter with a uprobe-event tracer.

Hmm, would you mean that these filters are currently not used?
If so, it would be better to remove this from the series, and
send again with an actual user code.

Thank you,

>
> Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> ---
> include/linux/uprobes.h | 5 +++++
> kernel/uprobes.c | 50 +++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 55 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/uprobes.h b/include/linux/uprobes.h
> index 26c4d78..34b989f 100644
> --- a/include/linux/uprobes.h
> +++ b/include/linux/uprobes.h
> @@ -65,6 +65,11 @@ struct uprobe_consumer {
> struct uprobe_consumer *next;
> };
>
> +struct uprobe_simple_consumer {
> + struct uprobe_consumer consumer;
> + pid_t fvalue;
> +};
> +
> struct uprobe {
> struct rb_node rb_node; /* node in the rb tree */
> atomic_t ref;
> diff --git a/kernel/uprobes.c b/kernel/uprobes.c
> index cdd52d0..c950f13 100644
> --- a/kernel/uprobes.c
> +++ b/kernel/uprobes.c
> @@ -1389,6 +1389,56 @@ int uprobe_post_notifier(struct pt_regs *regs)
> return 0;
> }
>
> +bool uprobes_pid_filter(struct uprobe_consumer *self, struct task_struct *t)
> +{
> + struct uprobe_simple_consumer *usc;
> +
> + usc = container_of(self, struct uprobe_simple_consumer, consumer);
> + if (t->tgid == usc->fvalue)
> + return true;
> + return false;
> +}
> +
> +bool uprobes_tid_filter(struct uprobe_consumer *self, struct task_struct *t)
> +{
> + struct uprobe_simple_consumer *usc;
> +
> + usc = container_of(self, struct uprobe_simple_consumer, consumer);
> + if (t->pid == usc->fvalue)
> + return true;
> + return false;
> +}
> +
> +bool uprobes_ppid_filter(struct uprobe_consumer *self, struct task_struct *t)
> +{
> + pid_t pid;
> + struct uprobe_simple_consumer *usc;
> +
> + usc = container_of(self, struct uprobe_simple_consumer, consumer);
> + rcu_read_lock();
> + pid = task_tgid_vnr(t->real_parent);
> + rcu_read_unlock();
> +
> + if (pid == usc->fvalue)
> + return true;
> + return false;
> +}
> +
> +bool uprobes_sid_filter(struct uprobe_consumer *self, struct task_struct *t)
> +{
> + pid_t pid;
> + struct uprobe_simple_consumer *usc;
> +
> + usc = container_of(self, struct uprobe_simple_consumer, consumer);
> + rcu_read_lock();
> + pid = pid_vnr(task_session(t));
> + rcu_read_unlock();
> +
> + if (pid == usc->fvalue)
> + return true;
> + return false;
> +}
> +
> struct notifier_block uprobes_exception_nb = {
> .notifier_call = uprobes_exception_notify,
> .priority = 0x7ffffff0,

--
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com


\
 
 \ /
  Last update: 2011-04-05 03:29    [W:0.415 / U:1.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site