Messages in this thread | | | Date | Sat, 30 Apr 2011 14:35:26 +0200 | From | Tejun Heo <> | Subject | Re: [PATCH] x86, NUMA: Fix empty memblk detection in numa_cleanup_meminfo() |
| |
On Sat, Apr 30, 2011 at 02:33:30PM +0200, Tejun Heo wrote: > From: Yinghai Lu <yinghai@kernel.org> > > numa_cleanup_meminfo() trims each memblk between low (0) and high > (max_pfn) limits and discard empty ones. However, the emptiness > detection incorrectly used equality test. If the start of a memblk is > higher than max_pfn, it is empty but fails the equality test and > doesn't get discarded. > > Fix it by using >= instead of ==. > > Signed-off-by: Yinghai Lu <yinghai@kernel.org> > Signed-off-by: Tejun Heo <tj@kernel.org> > --- > So, something like this. Does this fix the problem you see?
Ooh, this is before the code is moved to numa.c, so please test the previous patch against numa.c.
Thanks.
-- tejun
| |