Messages in this thread | | | Subject | Re: [RESEND PATCH 1/2] perf probe: Fix the missed parameter initialization | From | Lin Ming <> | Date | Sat, 30 Apr 2011 12:14:54 +0800 |
| |
On Sat, 2011-04-30 at 01:33 +0800, Arnaldo Carvalho de Melo wrote: > Em Fri, Apr 29, 2011 at 08:41:57AM +0000, Lin Ming escreveu: > > pubname_callback_param::found should be initialized to 0 in fastpath lookup. > > > Is this really needed? Or is this just to stress it, for documentational > purposes?
Yes, this is really needed.
It should be initialized to 0, and pubname_search_cb will set it to 1 if the function is found.
> > > Signed-off-by: Lin Ming <ming.m.lin@intel.com> > > --- > > tools/perf/util/probe-finder.c | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c > > index a7c7145..3b9d0b8 100644 > > --- a/tools/perf/util/probe-finder.c > > +++ b/tools/perf/util/probe-finder.c > > @@ -1538,6 +1538,7 @@ static int find_probes(int fd, struct probe_finder *pf) > > .file = pp->file, > > .cu_die = &pf->cu_die, > > .sp_die = &pf->sp_die, > > + .found = 0, > > }; > > struct dwarf_callback_param probe_param = { > > .data = pf, > > -- > > 1.7.4.4
| |