Messages in this thread | | | Date | Fri, 29 Apr 2011 08:55:11 +0530 | From | viresh kumar <> | Subject | Re: [PATCH V3 3/7] dmaengine/dw_dmac: don't call callback routine in case dmaengine_terminate_all() is called |
| |
On 04/28/2011 10:41 PM, Russell King - ARM Linux wrote: >> > static void >> > -dwc_descriptor_complete(struct dw_dma_chan *dwc, struct dw_desc *desc) >> > +dwc_descriptor_complete(struct dw_dma_chan *dwc, struct dw_desc *desc, >> > + bool callback_required) > If you're using 'bool' then using 'true' and 'false' with it rather than > '1' and '0' is a good idea.
Yes, will correct this.
-- viresh
| |