lkml.org 
[lkml]   [2011]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] audio: tlv320aic26: fix PLL register configuration
On Thu, Apr 28, 2011 at 5:56 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Thu, Apr 28, 2011 at 05:32:57PM -0400, Michael Williamson wrote:
>
>> -     jval = (fsref == 44100) ? 7 : 8;
>> -     dval = (fsref == 44100) ? 5264 : 1920;
>> +     jval = fsref / (aic26->mclk / 2048);
>> +     dval = fsref - jval * (aic26->mclk / 2048);
>
> I'd like some more brackets on this line, especially given the
> similarity with the previous line.  Otherwise this looks fine if a bit
> magic:

I will add some parens (and comment the magic?) and resubmit with your ack.

Thanks.

>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-04-29 00:25    [W:0.035 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site