lkml.org 
[lkml]   [2011]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] audio: tlv320aic26: fix PLL register configuration
On Thu, Apr 28, 2011 at 05:32:57PM -0400, Michael Williamson wrote:

> - jval = (fsref == 44100) ? 7 : 8;
> - dval = (fsref == 44100) ? 5264 : 1920;
> + jval = fsref / (aic26->mclk / 2048);
> + dval = fsref - jval * (aic26->mclk / 2048);

I'd like some more brackets on this line, especially given the
similarity with the previous line. Otherwise this looks fine if a bit
magic:

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>


\
 
 \ /
  Last update: 2011-04-28 23:59    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site