lkml.org 
[lkml]   [2011]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V3 4/7] dmaengine/dw_dmac: Enable resubmission from callback routine.
    On Wed, Apr 27, 2011 at 03:06:46PM +0530, Viresh Kumar wrote:
    > static void
    > dwc_descriptor_complete(struct dw_dma_chan *dwc, struct dw_desc *desc,
    > - bool callback_required)
    > + bool callback_required, unsigned long flags)
    > {
    ...
    > if (callback_required) {
    > + spin_unlock_irqrestore(&dwc->lock, flags);
    > if (callback)
    > callback(param);
    > + spin_lock_irqsave(&dwc->lock, flags);

    Again, this isn't really on. It seems to me that this code needs some
    serious reworking.


    \
     
     \ /
      Last update: 2011-04-28 19:15    [W:0.020 / U:29.716 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site