Messages in this thread | | | Date | Thu, 28 Apr 2011 18:12:27 +0100 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH V3 4/7] dmaengine/dw_dmac: Enable resubmission from callback routine. |
| |
On Wed, Apr 27, 2011 at 03:06:46PM +0530, Viresh Kumar wrote: > static void > dwc_descriptor_complete(struct dw_dma_chan *dwc, struct dw_desc *desc, > - bool callback_required) > + bool callback_required, unsigned long flags) > { ... > if (callback_required) { > + spin_unlock_irqrestore(&dwc->lock, flags); > if (callback) > callback(param); > + spin_lock_irqsave(&dwc->lock, flags);
Again, this isn't really on. It seems to me that this code needs some serious reworking.
| |