lkml.org 
[lkml]   [2011]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC 5/8] compaction: remove active list counting
    On Wed, Apr 27, 2011 at 01:25:22AM +0900, Minchan Kim wrote:
    > acct_isolated of compaction uses page_lru_base_type which returns only
    > base type of LRU list so it never returns LRU_ACTIVE_ANON or LRU_ACTIVE_FILE.
    > So it's pointless to add lru[LRU_ACTIVE_[ANON|FILE]] to get sum.
    >
    > Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
    > Cc: Mel Gorman <mgorman@suse.de>
    > Cc: Rik van Riel <riel@redhat.com>
    > Cc: Andrea Arcangeli <aarcange@redhat.com>
    > Signed-off-by: Minchan Kim <minchan.kim@gmail.com>

    hmm, isolate_migratepages() is doing a linear scan of PFNs and is
    calling __isolate_lru_page(..ISOLATE_BOTH..). Using page_lru_base_type
    happens to work because we're only interested in the number of isolated
    pages and your patch still covers that. Using page_lru might be more
    accurate in terms of accountancy but does not seem necessary.

    Adding a comment explaining why we account for it as inactive and why
    that's ok would be nice although I admit this is something I should have
    done when acct_isolated() was introduced.

    --
    Mel Gorman
    SUSE Labs


    \
     
     \ /
      Last update: 2011-04-28 12:53    [W:0.019 / U:1.924 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site