lkml.org 
[lkml]   [2011]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] rcu: export rcu_note_context_switch() function
On Thu, Apr 28, 2011 at 01:01:04PM +0300, Avi Kivity wrote:
> On 04/28/2011 12:52 PM, Gleb Natapov wrote:
> >Signed-off-by: Gleb Natapov<gleb@redhat.com>
> >@@ -93,11 +93,7 @@ static inline int rcu_needs_cpu(int cpu)
> >
> > #endif /* #else #ifdef CONFIG_TINY_RCU */
> >
> >-static inline void rcu_note_context_switch(int cpu)
> >-{
> >- rcu_sched_qs(cpu);
> >- rcu_preempt_note_context_switch();
> >-}
> >+extern void rcu_note_context_switch(int cpu);
> >
>
> Why are you uninlining this function? Why not export the two
> functions it calls instead?
>
To keep exported interface uniformal between both rcu implementations.
I do not think that rcu_note_context_switch() is inlined for
performance reason since two functions it calls are quite big in rcutiny
implementation. Paul what do you think?

--
Gleb.


\
 
 \ /
  Last update: 2011-04-28 12:13    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site