Messages in this thread | | | Date | Wed, 27 Apr 2011 09:56:06 +0200 | Subject | Re: [PATCH 2/2] init/Kconfig: use if/endif to surround the EXPERT menu kconfig symbols | From | Geert Uytterhoeven <> |
| |
On Wed, Apr 27, 2011 at 01:09, David Rientjes <rientjes@google.com> wrote: > On Tue, 26 Apr 2011, Randy Dunlap wrote: > >> From: Randy Dunlap <randy.dunlap@oracle.com> >> >> Surround the EXPERT menu with "if EXPERT" and "endif" so that it >> is forced to stay as one unit. Hopefully this will help to prevent >> it being broken in the future. >> >> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> >> Cc: David Rientjes <rientjes@google.com> >> Cc: Peter Foley <pefoley2@verizon.net> >> --- >> init/Kconfig | 36 ++++++++++++++++++++---------------- >> 1 file changed, 20 insertions(+), 16 deletions(-) >> >> --- lnx-2639-rc4.orig/init/Kconfig >> +++ lnx-2639-rc4/init/Kconfig >> @@ -924,15 +924,17 @@ menuconfig EXPERT >> environments which can tolerate a "non-standard" kernel. >> Only use this if you really know what you are doing. >> >> +if EXPERT >> + >> config UID16 >> - bool "Enable 16-bit UID system calls" if EXPERT >> + bool "Enable 16-bit UID system calls" >> depends on ARM || BLACKFIN || CRIS || FRV || H8300 || X86_32 || M68K || (S390 && !64BIT) || SUPERH || SPARC32 || (SPARC64 && COMPAT) || UML || (X86_64 && IA32_EMULATION) >> default y >> help >> This enables the legacy 16-bit UID syscall wrappers. >> > > I don't like this, people who look up a Kconfig option typically only > look at the single entry and look for dependencies within it, not the > context in which it is declared in the Kconfig file.
What about extracting the part that depends on EXPERT into its own file init/Kconfig.expert?
Using separate Kconfig.xxx files could become a Kconfig pattern...
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |