[lkml]   [2011]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCHv3 4/7] ethtool: cosmetic: Use ethtool ethtool_cmd_speed API
    On Wed, 2011-04-27 at 18:27 -0700, David Decotigny wrote:
    > This updates the network drivers so that they don't access the
    > ethtool_cmd::speed field directly, but use ethtoo_cmd_speed() instead.
    > For most drivers, these changes are purely cosmetic and don't
    > fix any problem, such as for those 1GbE/10GbE drivers that indirectly
    > call their own ethtool get_settings()/mii_ethtool_gset(). The changes
    > are meant to enforce code consistency and provide robustness with
    > future larger throughputs, at the expense of a few CPU cycles for each
    > ethtool operation.
    > All the drivers compiled with make allyesconfig ion x86_64 have been
    > updated.
    > Tested: make allyesconfig on x86_64 + e1000e/bnx2x work
    > Signed-off-by: David Decotigny <>
    Reviewed-by: Ben Hutchings <>

    Ben Hutchings, Senior Software Engineer, Solarflare
    Not speaking for my employer; that's the marketing department's job.
    They asked us to note that Solarflare product names are trademarked.

     \ /
      Last update: 2011-04-28 04:15    [W:0.021 / U:4.500 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site