Messages in this thread | | | Date | Thu, 28 Apr 2011 08:42:28 +0900 | Subject | Re: [RFC 5/8] compaction: remove active list counting | From | Minchan Kim <> |
| |
On Wed, Apr 27, 2011 at 5:15 PM, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote: > On Wed, 27 Apr 2011 01:25:22 +0900 > Minchan Kim <minchan.kim@gmail.com> wrote: > >> acct_isolated of compaction uses page_lru_base_type which returns only >> base type of LRU list so it never returns LRU_ACTIVE_ANON or LRU_ACTIVE_FILE. >> So it's pointless to add lru[LRU_ACTIVE_[ANON|FILE]] to get sum. >> >> Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> >> Cc: Mel Gorman <mgorman@suse.de> >> Cc: Rik van Riel <riel@redhat.com> >> Cc: Andrea Arcangeli <aarcange@redhat.com> >> Signed-off-by: Minchan Kim <minchan.kim@gmail.com> > > I think some comments are necessary to explain why INACTIVE only.
As alternative, I can change page_lru_base_type with page_lru. It's not hot path so I will do.
Thanks, Kame.
> Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
-- Kind regards, Minchan Kim
| |