lkml.org 
[lkml]   [2011]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] linux/string.h: Introduce streq macro.
On Wed, Apr 27, 2011 at 04:47:40AM -0400, gmack@innerfire.net wrote:
> Knowing about it and not screwing it up are two different things. I was
> working on a project a few years ago and we made this exact change thanks
> to the backwards logic of strcmp constantly screwing people up and the bug
> count went down considerably.

If someone could even vaguely possibly screw up strcmp(), I don't want
them submitting patches to my subsystem. I'm generally worried about
far more subtle bugs (deadlocks, locking screwups), and as Christoph
said, if you can't notice a strcmp bug, there's something
***seriousl**** wrong with your code review process, test suite,
testing discpline, or all of the above.

I would consider patches to change !strcmp() to streq() in any code I
maintain to be worse noise than spelling patches, or whitespace
patches.

- Ted


\
 
 \ /
  Last update: 2011-04-27 16:55    [W:0.110 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site