Messages in this thread | | | Date | Wed, 27 Apr 2011 10:52:09 -0400 | From | Ted Ts'o <> | Subject | Re: [PATCH] linux/string.h: Introduce streq macro. |
| |
On Wed, Apr 27, 2011 at 04:47:40AM -0400, gmack@innerfire.net wrote: > Knowing about it and not screwing it up are two different things. I was > working on a project a few years ago and we made this exact change thanks > to the backwards logic of strcmp constantly screwing people up and the bug > count went down considerably.
If someone could even vaguely possibly screw up strcmp(), I don't want them submitting patches to my subsystem. I'm generally worried about far more subtle bugs (deadlocks, locking screwups), and as Christoph said, if you can't notice a strcmp bug, there's something ***seriousl**** wrong with your code review process, test suite, testing discpline, or all of the above.
I would consider patches to change !strcmp() to streq() in any code I maintain to be worse noise than spelling patches, or whitespace patches.
- Ted
| |