Messages in this thread |  | | | Date | Wed, 27 Apr 2011 15:19:37 +0200 | | Subject | Re: [patch] m68k, mm: set all online nodes in N_NORMAL_MEMORY | | From | Geert Uytterhoeven <> |
| |
On Tue, Apr 26, 2011 at 12:50, Thorsten Glaser <tg@mirbsd.de> wrote: > Michael Schmitz dixit: > >> be done unconditionally since information about present memory has not >> yet >> been recorded. >> If N_NORMAL_MEMORY is not accurate, slub may encounter >> errors since it > > Hrm… > >> @@ -300,6 +300,8 @@ void __init paging_init(void) >> zones_size[ZONE_DMA] = m68k_memory[i].size >> PAGE_SHIFT; >> free_area_init_node(i, zones_size, >> m68k_memory[i].addr >> PAGE_SHIFT, NULL); >> + if (node_present_pages(i)) >> + node_set_state(i, N_NORMAL_MEMORY); >> } >> } > > No, this has whitespace problems (tabs are expanded to spaces).
Fixed those up, applied, and will send to Linus for 2.6.39-final.
BTW, if I enable CONFIG_SLUB on my ARAnyM setup, I don't get a crash, but it hangs after:
| INIT: version 2.86 booting
With Michael's patch, it continues fine.
Gr{oetje,eeting}s, Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |