Messages in this thread | | | Date | Wed, 27 Apr 2011 15:04:06 +0200 | From | Tejun Heo <> | Subject | Re: [PATCH v2 5/6] signal: sys_sigprocmask() needs retarget_shared_pending() |
| |
Hello,
Just my 5 cents.
On Wed, Apr 27, 2011 at 02:57:10PM +0200, Oleg Nesterov wrote: > Yes, sigprocmask(how) is ugly, but there are sys_rt_sigprocmask() and > sys_sigprocmask() which have to handle these SIG_* operations anyway. > So, I think we should do: > > 1. Almost all callers of sigprocmask() use SIG_SETMASK, we can > simply change them to use set_current_blocked().
I agree. We don't need to worry about atomicity here, so there's no reason to encode bitops (be it and/or or andn/xor) when the determination of the new value can be simply done in the caller.
Thanks.
-- tejun
| |