Messages in this thread Patch in this message | | | Date | Wed, 27 Apr 2011 12:36:22 +0200 | From | Michał Mirosław <> | Subject | Re: linux-next: ibmveth runtime errors |
| |
On Wed, Apr 27, 2011 at 02:49:01PM +1000, Stephen Rothwell wrote: > For the last couple of days, linux-next booting on a few of our Power > partitions (but not all) have produced this error (over and over): > > ibmveth 3000000b: eth0: tx: h_send_logical_lan failed with rc=-4 > > Linus' tree seems to boot fine on these partitions. The only commit > directly affecting ibmveth in linux-next is b9367bf3ee6d ("net: ibmveth: > convert to hw_features") which first appeared in next-20110421 which is > also the first one that failed.
Please test the following patch. It's just a blind guess, as this error is not descriptive.
Best Regards, Michał Mirosław
---
net: ibmveth: force reconfiguring checksum settings on startup
Commit b9367bf3ee6d ("net: ibmveth: convert to hw_features") accidentally removed call to ibmveth_set_csum_offload() in ibmveth_probe(). Put the call back where it was, but with additional error checking provided by ibmveth_set_features().
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
--- drivers/net/ibmveth.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ibmveth.c b/drivers/net/ibmveth.c index 4855f1f..0d1fea2 100644 --- a/drivers/net/ibmveth.c +++ b/drivers/net/ibmveth.c @@ -1397,6 +1397,8 @@ static int __devinit ibmveth_probe(struct vio_dev *dev, netdev_dbg(netdev, "registering netdev...\n"); + ibmveth_set_features(dev, dev->features); + rc = register_netdev(netdev); if (rc) { -- 1.7.2.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |