Messages in this thread | | | Date | Wed, 27 Apr 2011 09:17:07 +0530 | From | viresh kumar <> | Subject | Re: [PATCH 1/6] dmaengine/dw_dmac: Replace spin_lock_bh with irqsave variants |
| |
On 04/27/2011 02:03 AM, Russell King - ARM Linux wrote: > On Tue, Apr 19, 2011 at 11:55:45AM +0530, viresh kumar wrote: >> This must have been added in dw_dma_chan instead :( >> Will resend it. > > Even that doesn't work. It has to be a local variable.
I assumed that flags wouldn't be updated if lock is already taken by some other thread. In which case global flags would have worked fine. But as i see now, that's incorrect. Flags is always changed, whether or not lock is taken.
Will resend it again.
-- viresh
| |