lkml.org 
[lkml]   [2011]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] linux/string.h: Introduce streq macro.
    On Tue, Apr 26, 2011 at 03:49:49PM -0300, Thiago Farina wrote:
    > This macro is arguably more readable than its variants:
    > - !strcmp(a, b)
    > - strcmp(a, b) == 0
    >
    > Signed-off-by: Thiago Farina <tfransosi@gmail.com>

    I don't think this is not a good idea.

    First of all, changing 2800 instances of strcmp will induce a huge
    amount of code churn, that will cause patches to break, etc. And
    whether streq() looks better is going to be very much a case of
    personal preference. I'm so used to !strcmp(a, b) that streq(a, b)
    would be harder for me, just because I'm not used to it.

    So I'd NACK a change like this to any parts of the kernel that I'm
    maintaining. If another people feel that way, it's not clear that
    having two different conventions in the kernel would necessarily help...

    - Ted


    \
     
     \ /
      Last update: 2011-04-27 02:55    [W:4.133 / U:0.304 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site