Messages in this thread | | | Subject | Re: [PATCH v2 1/5] dmaengine: at_hdmac: modify way to use interrupts | From | "Koul, Vinod" <> | Date | Tue, 26 Apr 2011 09:36:56 +0530 |
| |
On Tue, 2011-04-26 at 09:32 +0530, Koul, Vinod wrote: > On Fri, 2011-04-22 at 19:41 +0200, Nicolas Ferre wrote: > > Now we use Buffer Transfer Completed interrupts. If we > > want a chained buffer completed information, we setup the > > ATC_IEN bit in CTRLB register in the lli. > > This is done by set_desc_eol() function and used by > > memcpy/slave_sg functions. > > > > Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com> > > --- > > drivers/dma/at_hdmac.c | 4 ++-- > > drivers/dma/at_hdmac_regs.h | 11 ++++++++--- > > 2 files changed, 10 insertions(+), 5 deletions(-) > > > > > Looks like your forgot to run checkpatch > WARNING: line over 80 characters > #401: FILE: drivers/dma/at_hdmac_regs.h:106: > +#define MEM_IF 0 /* specify AHB interface 0 as memory interface */ > > WARNING: line over 80 characters > #402: FILE: drivers/dma/at_hdmac_regs.h:107: > +#define PER_IF 1 /* specify AHB interface 1 as peripheral interface > */ > > WARNING: line over 80 characters > #689: FILE: drivers/dma/at_hdmac.c:899: > + direction == DMA_TO_DEVICE ? "TO DEVICE" : "FROM DEVICE", > > total: 0 errors, 3 warnings, 465 lines checked > > While I am okay with 3rd one, you can easily reformat code for first two > and avoid these two warnings... > And your 4th patch fails to apply on my tree, please rebase these to my tree as well
-- ~Vinod
| |