| From | Andi Kleen <> | Subject | [PATCH] [17/106] UBIFS: do not read flash unnecessarily | Date | Tue, 26 Apr 2011 14:12:55 -0700 (PDT) |
| |
2.6.35-longterm review patch. If anyone has any objections, please let me know.
------------------ From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
commit 8b229c76765816796eec7ccd428f03bd8de8b525 upstream.
This fix makes the 'dbg_check_old_index()' function return immediately if debugging is disabled, instead of executing incorrect 'goto out' which causes UBIFS to:
1. Allocate memory 2. Read the flash
On every commit. OK, we do not commit that often, but it is still silly to do unneeded I/O anyway.
Credits to coverity for spotting this silly issue.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by: Andi Kleen <ak@linux.intel.com>
--- fs/ubifs/commit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.35.y/fs/ubifs/commit.c =================================================================== --- linux-2.6.35.y.orig/fs/ubifs/commit.c +++ linux-2.6.35.y/fs/ubifs/commit.c @@ -519,7 +519,7 @@ int dbg_check_old_index(struct ubifs_inf size_t sz; if (!(ubifs_chk_flags & UBIFS_CHK_OLD_IDX)) - goto out; + return 0; INIT_LIST_HEAD(&list);
|