Messages in this thread | | | Subject | Re: [PATCH] linux/string.h: Introduce streq macro. | From | Steven Rostedt <> | Date | Tue, 26 Apr 2011 15:25:00 -0400 |
| |
On Tue, 2011-04-26 at 22:20 +0300, Alexey Dobriyan wrote: > On Tue, Apr 26, 2011 at 03:17:48PM -0400, Steven Rostedt wrote: > > On Tue, 2011-04-26 at 22:05 +0300, Alexey Dobriyan wrote: > > > On Tue, Apr 26, 2011 at 03:49:49PM -0300, Thiago Farina wrote: > > > > > /** > > > > + * streq - Are two strings equal? > > > > + * @a: first string > > > > + * @b: second string > > > > + * > > > > + * Example: > > > > + * if (streq(argv[1], "--help")) > > > > + * printf("%s\n", "This help"); > > > > Userspace example? > > The point is that function is trivial, and if someone doesn't > understand it, he should read some Kernighan and Ritchie first.
I understood your point, but I missed looking at it in my first reply. I'm just stating that it is even worse since it includes a userspace example of a macro defined in the kernel. IOW, the example wont even work.
-- Steve
| |