| | Date | Tue, 26 Apr 2011 12:51:50 -0400 | | From | Christoph Hellwig <> | | Subject | Re: [PATCH 20/25] Staging: hv: Use the probe function in struct hv_driver |
| |
> @@ -882,7 +882,7 @@ static int blkvsc_drv_init(void) > > drv->driver.name = storvsc_drv_obj->base.name; > > - drv->driver.probe = blkvsc_probe; > + drv->probe = blkvsc_probe; > drv->driver.remove = blkvsc_remove; > drv->driver.shutdown = blkvsc_shutdown;
Not new in this patch, but you should really declare the driver as a static object and initialize it at compile time, similar to how it's done for PCI and countless other busses, e.g.
struct hv_driver blkvsc_driver { .name = "blkvsc", .probe = blkvsc_probe, .remove = blkvsc_remove, .shutdown = blkvsc_shutdown, };
|