lkml.org 
[lkml]   [2011]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 20/25] Staging: hv: Use the probe function in struct hv_driver
    > @@ -882,7 +882,7 @@ static int blkvsc_drv_init(void)
    >
    > drv->driver.name = storvsc_drv_obj->base.name;
    >
    > - drv->driver.probe = blkvsc_probe;
    > + drv->probe = blkvsc_probe;
    > drv->driver.remove = blkvsc_remove;
    > drv->driver.shutdown = blkvsc_shutdown;

    Not new in this patch, but you should really declare the driver as a
    static object and initialize it at compile time, similar to how it's
    done for PCI and countless other busses, e.g.

    struct hv_driver blkvsc_driver {
    .name = "blkvsc",
    .probe = blkvsc_probe,
    .remove = blkvsc_remove,
    .shutdown = blkvsc_shutdown,
    };



    \
     
     \ /
      Last update: 2011-04-26 18:55    [W:0.025 / U:89.924 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site