Messages in this thread |  | | | Date | Tue, 26 Apr 2011 11:28:04 +0100 | | From | Matt Fleming <> | | Subject | Re: [PATCH 2/3] signal: introduce do_sigtimedwait() to factor out compat/native code |
| |
On Sat, 23 Apr 2011 19:59:40 +0200 Oleg Nesterov <oleg@redhat.com> wrote:
> Factor out the common code in sys_rt_sigtimedwait/compat_sys_rt_sigtimedwait > to the new helper, do_sigtimedwait(). > > Perhaps it would be better to move compat_sys_rt_sigtimedwait() into > signal.c under CONFIG_COMPAT, then we can make do_sigtimedwait() static. > > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Reviewed-by: Matt Fleming <matt.fleming@linux.intel.com>
The changes Tejun suggested seem like a good idea. I also think that moving compat_sys_rt_sigtimedwait() into signal.c makes sense.
-- Matt Fleming, Intel Open Source Technology Center
|  |