lkml.org 
[lkml]   [2011]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 5/7] signal: sigprocmask() should do retarget_shared_pending()
    Hey, again.

    > Signed-off-by: Oleg Nesterov <oleg@redhat.com>

    Acked-by: Tejun Heo <tj@kernel.org>

    But, I really think we can use some comments around here. Things
    might look obvious now but it isn't very intuitive piece of code.

    > +void set_current_blocked(const sigset_t *newset)
    > +{
    > + struct task_struct *tsk = current;
    > +
    > + spin_lock_irq(&tsk->sighand->siglock);
    > + if (signal_pending(tsk) && !thread_group_empty(tsk)) {
    > + sigset_t newblocked;
    > + signandsets(&newblocked, newset, &current->blocked);

    While you're touching code around here, can you please rename
    signandsets() to sigandnsets()? It ain't nand!!!

    Thanks.

    --
    tejun


    \
     
     \ /
      Last update: 2011-04-25 13:17    [W:0.023 / U:29.656 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site