| | Date | Mon, 25 Apr 2011 12:52:29 +0200 | | From | Tejun Heo <> | | Subject | Re: [PATCH v2 2/7] signal: retarget_shared_pending: consider shared/unblocked signals only |
| |
On Mon, Apr 18, 2011 at 03:45:01PM +0200, Oleg Nesterov wrote: > -static void retarget_shared_pending(struct task_struct *tsk) > +static void retarget_shared_pending(struct task_struct *tsk, sigset_t *set)
Hmm... @set? Maybe a name which refelcts its purpose, say @target or @consider would be better? Also, it would be really great to have docbook function comment describing the parameter.
Other than that,
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
-- tejun
|