lkml.org 
[lkml]   [2011]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [TRIVIAL PATCH] treewide: Cleanup continuations and remove logging message whitespace
On Mon, Apr 25, 2011 at 08:22:30AM -0700, Randy Dunlap wrote:
> On Sat, 23 Apr 2011 20:38:19 -0700 Joe Perches wrote:
>
> > Using C line continuation inside format strings is error prone.
> > Clean up the unintended whitespace introduced by misuse of \.
> > Neaten correctly used line continations as well for consistency.
> >
> > drivers/scsi/arcmsr/arcmsr_hba.c has these errors as well,
> > but arcmsr needs a lot more work and the driver should likely be
> > moved to staging instead.
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
>
Acked-by: Harry Wei <harryxiyou@gmail.com>
>
>
> Joe,
> Is there a decent fix for this warning in linux-next:
>
> drivers/tty/n_gsm.c:535: warning: zero-length gnu_printf format string
Hi Randy & Joe,
I have seen the drivers/tty/n_gsm.c.
From line 529 to line 540 in drivers/tty/n_gsm.c like following.

529 static void hex_packet(const unsigned char *p, int len)
530 {
531 int i;
532 for (i = 0; i < len; i++) {
533 if (i && (i % 16) == 0) {
534 pr_cont("\n");
535 pr_debug("");
536 }
537 pr_cont("%02X ", *p++);
538 }
539 pr_cont("\n");
540 }

Should we need the line 535? If true, i wanna the function of
'pr_debug("");'

Thanks.
Harry Wei.


\
 
 \ /
  Last update: 2011-04-26 04:51    [W:0.116 / U:0.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site