lkml.org 
[lkml]   [2011]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] misc: add real function open/read/write/ioctl/close for moxa_serial_io driver
    On Sun, Apr 24, 2011 at 07:47:23PM -0700, Joe Perches wrote:
    > On Mon, 2011-04-25 at 10:35 +0800, Jimmy Chen (陳永達) wrote:
    > > Add real function and GPL license.
    > > Signed-off-by: Jimmy Chen <jimmy.chen@moxa.com>
    >
    > A few things.
    >
    > o Your patches are reversed.
    > o Please run your patches through checkpatch.
    > o I think it better to avoid duplicating all of the GPL
    > and just reference it as you have via MODULE_LICENSE.
    > o You could probably use MODULE_LICENSE("GPL V2")
    > if you want to limit it to V2 only.

    And finally, why does this need to be a kernel driver at all? Can't you
    do all of this from userspace without any kernel changes needed?

    thanks,

    greg k-h
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-04-25 05:07    [W:0.020 / U:0.516 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site