Messages in this thread | | | From | KOSAKI Motohiro <> | Date | Sun, 24 Apr 2011 15:04:10 +0900 | Subject | Re: [patch] m68k, mm: set all online nodes in N_NORMAL_MEMORY |
| |
2011/4/24 Michael Schmitz <schmitzmic@googlemail.com>: > Michael Schmitz wrote: >> >> Besides, your solution would set N_HIGH_MEMORY not N_NORMAL_MEMORY if I >> read free_area_init_nodes() right. Does that matter? > > check_for_regular_memory() does take care of that - so it would be all the > same in the end. Whether it's worth it for a handful of nodes at best I'm > unsure. I'll leave that for Geert to decide.
check_for_regular_memory() doesn't. It is CONFIG_HIGHMEM specific. The trick is in node_status definition. N_NORMAL_MEMORY and N_HIGHMEMORY share the same value. then node_set_state(nid, N_HIGH_MEMORY) turn on both normal and highmem bitmask.
-------------------------------------------------------------------- enum node_states { N_POSSIBLE, /* The node could become online at some point */ N_ONLINE, /* The node is online */ N_NORMAL_MEMORY, /* The node has regular memory */ #ifdef CONFIG_HIGHMEM N_HIGH_MEMORY, /* The node has regular or high memory */ #else N_HIGH_MEMORY = N_NORMAL_MEMORY, #endif N_CPU, /* The node has one or more cpus */ NR_NODE_STATES };
| |