lkml.org 
[lkml]   [2011]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sched: remove noop in alloc_rt_sched_group()
On Sat, Apr 23, 2011 at 09:29:05PM +0800, Hillf Danton wrote:
> The rq varible, though computed for each possible cpu, has nothing to
> do in the function, so it could be removed.
>
> Signed-off-by: Hillf Danton <dhillf@gmail.com>

Looks good.

Reviewed-by: Yong Zhang <yong.zhang0@gmail.com>

> ---
>
> --- a/kernel/sched.c 2011-03-30 03:09:48.000000000 +0800
> +++ b/kernel/sched.c 2011-04-23 21:23:48.000000000 +0800
> @@ -8539,7 +8539,6 @@ int alloc_rt_sched_group(struct task_gro
> {
> struct rt_rq *rt_rq;
> struct sched_rt_entity *rt_se;
> - struct rq *rq;
> int i;
>
> tg->rt_rq = kzalloc(sizeof(rt_rq) * nr_cpu_ids, GFP_KERNEL);
> @@ -8553,8 +8552,6 @@ int alloc_rt_sched_group(struct task_gro
> ktime_to_ns(def_rt_bandwidth.rt_period), 0);
>
> for_each_possible_cpu(i) {
> - rq = cpu_rq(i);
> -
> rt_rq = kzalloc_node(sizeof(struct rt_rq),
> GFP_KERNEL, cpu_to_node(i));
> if (!rt_rq)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/


\
 
 \ /
  Last update: 2011-04-23 16:15    [W:0.416 / U:0.136 seconds]
©2003-2014 Jasper Spaans. Advertise on this site