lkml.org 
[lkml]   [2011]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/4] perf, x86: P4 PMU -- Use perf_sample_data_init helper
    From
    yeah, it can wait

    On Friday, April 22, 2011, Ingo Molnar <mingo@elte.hu> wrote:
    >
    > * Don Zickus <dzickus@redhat.com> wrote:
    >
    >> From: Cyrill Gorcunov <gorcunov@gmail.com>
    >>
    >> Instead of opencoded assignments better to use
    >> perf_sample_data_init helper.
    >>
    >> Tested-by: Lin Ming <ming.m.lin@intel.com>
    >> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
    >> Signed-off-by: Don Zickus <dzickus@redhat.com>
    >> ---
    >>  arch/x86/kernel/cpu/perf_event_p4.c |    3 +--
    >>  1 files changed, 1 insertions(+), 2 deletions(-)
    >>
    >> diff --git a/arch/x86/kernel/cpu/perf_event_p4.c b/arch/x86/kernel/cpu/perf_event_p4.c
    >> index c2520e1..6f2bd89 100644
    >> --- a/arch/x86/kernel/cpu/perf_event_p4.c
    >> +++ b/arch/x86/kernel/cpu/perf_event_p4.c
    >> @@ -912,8 +912,7 @@ static int p4_pmu_handle_irq(struct pt_regs *regs)
    >>       int idx, handled = 0;
    >>       u64 val;
    >>
    >> -     data.addr = 0;
    >> -     data.raw = NULL;
    >> +     perf_sample_data_init(&data, 0);
    >
    > This one sure can wait for v2.6.40, right?
    >
    > Thanks,
    >
    >        Ingo
    >
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-04-22 10:39    [W:0.033 / U:0.284 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site