lkml.org 
[lkml]   [2011]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RFC PATCH 4/5] RCU: Add TASK_RCU_OFFSET
    From
    Date
    On Fri, 2011-04-22 at 15:19 +0800, Lai Jiangshan wrote:
    >
    > What is the solution you prefer to?
    >
    > I insist on the solution which split rcupdate.h into 2 parts,
    > the first part is rcupdate_defs.h which only contains:
    > 1) struct rcu_head
    > 2) MACRO rcu_dereference*
    > 3) MACRO rcu_access_pointer rcu_access_index rcu_assign_pointer RCU_INIT_POINTER
    > 4) rcu_*_lock_held() which is required by 2)
    >
    > All of these is required by sched.h, it is all about 450 lines of code.
    >
    > It does not just separate struct rcu_head out only, because rcu_dereference*()
    > and APIs in rculist.h are required by in sched.h or headers included by sched.h.

    The only usage of rculist.h in the whole of sched.h is that _one_
    list_entry_rcu, of which we already have a macro user, so why not make
    that one a macro too and safe ourselves a ton of grief?

    You're just making stuff harder than it needs to be.


    \
     
     \ /
      Last update: 2011-04-22 10:13    [W:0.021 / U:0.216 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site