lkml.org 
[lkml]   [2011]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Strange block/scsi/workqueue issue
Hello, guys.

On Wed, Apr 13, 2011 at 03:17:46PM -0500, James Bottomley wrote:
> On Wed, 2011-04-13 at 22:12 +0200, Jens Axboe wrote:
> > This patch looks pretty clean. Shouldn't you serialize that ->queuedata
> > = NULL assignment with the queue lock, though?
>
> pointer assignment is atomic, isn't it? As in on a 32 bit arch, it
> definitely is, and I thought on 64 bits it also was. So a simultaneous
> reader either sees previous value or NULL.

What was the conclusion of this thread? James' fix seems minimal and
good for this cycle but I don't see it there yet. Jens, James?

Thanks.

--
tejun


\
 
 \ /
  Last update: 2011-04-22 20:05    [W:1.097 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site